RE: [PATCH 0/6] bus: fsl-mc: Make remove function return void

From: Leo Li
Date: Wed Apr 12 2023 - 17:31:05 EST




> -----Original Message-----
> From: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> Sent: Wednesday, April 12, 2023 12:11 PM
> To: Stuart Yoder <stuyoder@xxxxxxxxx>; Laurentiu Tudor
> <laurentiu.tudor@xxxxxxx>; Roy Pledge <roy.pledge@xxxxxxx>; Leo Li
> <leoyang.li@xxxxxxx>; Horia Geanta <horia.geanta@xxxxxxx>; Pankaj
> Gupta <pankaj.gupta@xxxxxxx>; Gaurav Jain <gaurav.jain@xxxxxxx>;
> Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>; David S. Miller
> <davem@xxxxxxxxxxxxx>; Vinod Koul <vkoul@xxxxxxxxxx>; Ioana Ciornei
> <ioana.ciornei@xxxxxxx>; Eric Dumazet <edumazet@xxxxxxxxxx>; Jakub
> Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni <pabeni@xxxxxxxxxx>; Y.B. Lu
> <yangbo.lu@xxxxxxx>; Diana Madalina Craciun (OSS)
> <diana.craciun@xxxxxxxxxxx>; Alex Williamson
> <alex.williamson@xxxxxxxxxx>; Richard Cochran
> <richardcochran@xxxxxxxxx>
> Cc: kvm@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; linux-crypto@xxxxxxxxxxxxxxx;
> kernel@xxxxxxxxxxxxxx; dmaengine@xxxxxxxxxxxxxxx; linuxppc-
> dev@xxxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH 0/6] bus: fsl-mc: Make remove function return void
>
> Hello,
>
> On Fri, Mar 10, 2023 at 11:41:22PM +0100, Uwe Kleine-König wrote:
> > Hello,
> >
> > many bus remove functions return an integer which is a historic
> > misdesign that makes driver authors assume that there is some kind of
> > error handling in the upper layers. This is wrong however and
> > returning and error code only yields an error message.
> >
> > This series improves the fsl-mc bus by changing the remove callback to
> > return no value instead. As a preparation all drivers are changed to
> > return zero before so that they don't trigger the error message.
>
> Who is supposed to pick up this patch series (or point out a good reason for
> not taking it)?

Previously Greg KH picked up MC bus patches.

If no one is picking up them this time, I probably can take it through the fsl soc tree.

Regards,
Leo