Re: [PATCH net] net: bridge: switchdev: don't notify FDB entries with "master dynamic"

From: Ido Schimmel
Date: Wed Apr 12 2023 - 12:50:55 EST


On Wed, Apr 12, 2023 at 07:24:07PM +0300, Vladimir Oltean wrote:
> I'll send v2 with BR_FDB_ADDED_BY_EXT_LEARN not prevented from being
> notified from switchdev.
>
> Unless you have any objection, I won't send v2 like this:
>
> if (test_bit(BR_FDB_ADDED_BY_USER, &fdb->flags) &&
> !test_bit(BR_FDB_STATIC, &fdb->flags) &&
> !test_bit(BR_FDB_ADDED_BY_EXT_LEARN, &fdb->flags))
> return;
>
> but like this:
>
> /* Entries with just the BR_FDB_ADDED_BY_USER flag set were created
> * using 'bridge fdb add ... master dynamic'
> */
> if (fdb->flags == BIT(BR_FDB_ADDED_BY_USER))
> return;

LGTM. Please copy me on v2 and I will run it through regression. Will
try to report results before tomorrow's PR.

Thanks!