Re: [PATCH 1/2] blk-integrity: add rq_integrity_payload_size helper

From: Chaitanya Kulkarni
Date: Wed Apr 12 2023 - 01:43:30 EST



>> +
>> +static inline unsigned int rq_integrity_payload_size(struct request
>> *rq)
>> +{
>> +    if (WARN_ON_ONCE(queue_max_integrity_segments(rq->q) > 1))
>> +        return 0;
>> +    return rq->bio->bi_integrity->bip_iter.bi_size;
>> +}
>>   #else /* CONFIG_BLK_DEV_INTEGRITY */
>>   static inline int blk_rq_count_integrity_sg(struct request_queue *q,
>>                           struct bio *b)
>
> from the comments that I got in the past, you should only be adding
> a helper in the patch that is actually using it.
>
> -ck
>
>

disregard my comment, I think this is correct looking at the next patch...

-ck