Re: [PATCH net-next v4 11/12] net: stmmac: dwmac-qcom-ethqos: Use loopback_en for all speeds

From: Jesse Brandeburg
Date: Tue Apr 11 2023 - 19:46:36 EST


On 4/11/2023 1:04 PM, Andrew Halaney wrote:
> It seems that this variable should be used for all speeds, not just
> 1000/100.
>
> While at it refactor it slightly to be more readable, including fixing
> the typo in the variable name.
>
> Signed-off-by: Andrew Halaney <ahalaney@xxxxxxxxxx>

Would prefer the future use of bitfields in a u8 instead of a bool in
structs, but it's really a nit, and they're already there you're just
renaming them.

Reviewed-by: Jesse Brandeburg <jesse.brandeburg@xxxxxxxxx>