Re: [PATCH net-next v6 07/18] tcp: Support MSG_SPLICE_PAGES

From: David Howells
Date: Tue Apr 11 2023 - 13:50:46 EST


Eric Dumazet <edumazet@xxxxxxxxxx> wrote:

> > - zc = sk->sk_route_caps & NETIF_F_SG;
> > + if (sk->sk_route_caps & NETIF_F_SG)
> > + zc = 1;
>
> zc is set to 0, 1, MSG_ZEROCOPY , MSG_SPLICE_PAGES
>
> I find this a bit confusing. Maybe use a private enum ?

Meh. That should be "zc = MSG_ZEROCOPY;". Will fix.

David