Re: [PATCH 1/4] mfd: intel-m10-bmc: Move core symbols to own namespace

[Ilpo Järvinen]

On Fri, 7 Apr 2023, Xu Yilun wrote:

> On 2023-04-05 at 11:01:49 +0300, Ilpo Järvinen wrote:
> > Create INTEL_M10_BMC_CORE namespace for symbols exported by
> > intel-m10-bmc-core.
> 
> Is it necessary for handshake register, or just an independent
> improvement?

It's independent improvement.

> > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
> > ---
> >  drivers/mfd/intel-m10-bmc-core.c | 2 +-
> >  drivers/mfd/intel-m10-bmc-pmci.c | 1 +
> >  drivers/mfd/intel-m10-bmc-spi.c  | 1 +
> >  3 files changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/mfd/intel-m10-bmc-core.c b/drivers/mfd/intel-m10-bmc-core.c
> > index dac9cf7bcb4a..b94412813887 100644
> > --- a/drivers/mfd/intel-m10-bmc-core.c
> > +++ b/drivers/mfd/intel-m10-bmc-core.c
> > @@ -98,7 +98,7 @@ const struct attribute_group *m10bmc_dev_groups[] = {
> >  	&m10bmc_group,
> >  	NULL,
> >  };
> > -EXPORT_SYMBOL_GPL(m10bmc_dev_groups);
> > +EXPORT_SYMBOL_NS_GPL(m10bmc_dev_groups, INTEL_M10_BMC_CORE);
> >  
> >  int m10bmc_dev_init(struct intel_m10bmc *m10bmc, const struct intel_m10bmc_platform_info *info)
> 
> Why this function is not included in namespace?

It was not left out on purpose, I'll add it there.

-- 
 i.