Re: [PATCH v2 2/2] arm64: dts: qcom: Add base qrb4210-rb2 board dts

From: Bhupesh Sharma
Date: Mon Apr 10 2023 - 12:53:48 EST




On 3/16/23 5:22 AM, Konrad Dybcio wrote:


On 15.03.2023 23:36, Bjorn Andersson wrote:
On Thu, Mar 16, 2023 at 02:31:45AM +0530, Bhupesh Sharma wrote:
Add DTS for Qualcomm qrb4210-rb2 board which uses SM4250 SoC.

This adds debug uart, emmc, uSD and tlmm support along with
regulators found on this board.

Also defines the 'xo_board' and 'sleep_clk' frequencies for
this board.

Signed-off-by: Bhupesh Sharma <bhupesh.sharma@xxxxxxxxxx>
---
[...]

+ vmmc-supply = <&vreg_l24a_2p96>;

Is there any reason why this platform doesn't require the vmmc supply to
be driven to HPM? This has traditionally been coming back biting us
through some stability issues later.
Do we even support HPM/LPM on SMD RPM?

I couldn't find any relevant documentation to say the same (HPM/LPM support on SMD RPM?).
So, I would suggest that we stick to the approach used in this patch for now.

@Bjorn, please let me know in case of any concerns.

Thanks,
Bhupesh