Re: [PATCH net-next v4 00/14] sfc: add vDPA support for EF100 devices

From: Gautam Dawar
Date: Mon Apr 10 2023 - 02:35:05 EST



On 4/10/23 07:09, Jason Wang wrote:
Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.


On Sun, Apr 9, 2023 at 5:13 PM Leon Romanovsky <leon@xxxxxxxxxx> wrote:
On Fri, Apr 07, 2023 at 01:40:01PM +0530, Gautam Dawar wrote:
Hi All,

This series adds the vdpa support for EF100 devices.
For now, only a network class of vdpa device is supported and
they can be created only on a VF. Each EF100 VF can have one
of the three function personalities (EF100, vDPA & None) at
any time with EF100 being the default. A VF's function personality
is changed to vDPA while creating the vdpa device using vdpa tool.
Jakub,

I wonder if it is not different approach to something that other drivers
already do with devlink enable knobs (DEVLINK_PARAM_GENERIC_ID_ENABLE_*)
and auxiliary bus.
I think the auxiliary bus fits here, and I've proposed to use that in
V2 of this series.

Yeah, right and you mentioned that are fine with it if this is done sometime in future to which Martin responded saying the auxbus approach will be considered when re-designing sfc driver for the upcoming projects on the roadmap.

Gautam


Thanks

Thanks