Re: [PATCH 2/7] erofs: initialize packed inode after root inode is assigned

From: Gao Xiang
Date: Sun Apr 09 2023 - 06:52:32 EST




On 2023/4/7 22:17, Jingbo Xu wrote:
As commit 8f7acdae2cd4 ("staging: erofs: kill all failure handling in
fill_super()"), move the initialization of packed inode after root
inode is assigned, so that the iput() in .put_super() is adequate as
the failure handling.

Otherwise, iput() is also needed in .kill_sb(), in case of the mounting
fails halfway.


Fixes: b15b2e307c3a ("erofs: support on-disk compressed fragments data")

Signed-off-by: Jingbo Xu <jefflexu@xxxxxxxxxxxxxxxxx>

Reviewed-by: Gao Xiang <hsiangkao@xxxxxxxxxxxxxxxxx>

Thanks,
Gao Xiang