Re: [PATCH] scripts: rust: drop is_rust_module.sh

From: Masahiro Yamada
Date: Sat Apr 08 2023 - 09:44:51 EST


On Fri, Apr 7, 2023 at 4:05 PM Andrea Righi <andrea.righi@xxxxxxxxxxxxx> wrote:
>
> Commit c1177979af9c ("btf, scripts: Exclude Rust CUs with pahole")
> introduced the constraint "!DEBUG_INFO_BTF || PAHOLE_HAS_LANG_EXCLUDE"
> to enable RUST.
>
> With this constraint we don't need is_rust_module.sh anymore, because
> 'pahole --lang_exclude=rust' already has the capability to exclude Rust
> CUs. If pahole isn't recent enough (< 1.24) to support --lang_exclude,
> then DEBUG_INFO_BTF can't be enabled with RUST and is_rust_module.sh
> isn't used as well.
>
> In any case is_rust_module.sh is obsolete and we can just drop it.
>
> Link: https://lore.kernel.org/lkml/Y+p2xKIN6TJnQinK@righiandr-XPS-13-7390/
> Signed-off-by: Andrea Righi


Reviewed-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>


--
Best Regards
Masahiro Yamada