RE: [PATCH V3 3/4] ARM: dts: imx6ull-dhcor: Remove mmc aliases from SoM

From: Christoph Niedermaier
Date: Fri Apr 07 2023 - 06:47:22 EST


From: Krzysztof Kozlowski [mailto:krzk@xxxxxxxxxx]
Sent: Friday, April 7, 2023 8:57 AM
> On 06/04/2023 23:53, Christoph Niedermaier wrote:
>> Remove mmc aliases to be able to define them correctly in the board file.
>>
>> Signed-off-by: Christoph Niedermaier <cniedermaier@xxxxxxxxxxxxxxxxxx>
>> ---
>> Cc: Rob Herring <robh+dt@xxxxxxxxxx>
>> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>
>> Cc: Shawn Guo <shawnguo@xxxxxxxxxx>
>> Cc: Li Yang <leoyang.li@xxxxxxx>
>> Cc: Marek Vasut <marex@xxxxxxx>
>> Cc: Fabio Estevam <festevam@xxxxxxx>
>> Cc: NXP Linux Team <linux-imx@xxxxxxx>
>> Cc: kernel@xxxxxxxxxxxxxxxxxx
>> Cc: devicetree@xxxxxxxxxxxxxxx
>> Cc: linux-kernel@xxxxxxxxxxxxxxx
>> To: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
>> ---
>> V3: - Add this patch to the series
>> ---
>> arch/arm/boot/dts/imx6ull-dhcor-som.dtsi | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/imx6ull-dhcor-som.dtsi b/arch/arm/boot/dts/imx6ull-dhcor-som.dtsi
>> index 5882c7565f64..a386c1e9bed3 100644
>> --- a/arch/arm/boot/dts/imx6ull-dhcor-som.dtsi
>> +++ b/arch/arm/boot/dts/imx6ull-dhcor-som.dtsi
>> @@ -11,6 +11,11 @@
>> #include "imx6ull.dtsi"
>>
>> / {
>> + aliases {
>> + /delete-property/ mmc0;
>> + /delete-property/ mmc1;
>> + };
>
> You need to re-add them in respective boards: drc02, pdk2 and picoitx.
> Otherwise you just removed that functionality without any explanation in
> commit msg.

For the drc02, pdk2 and picoitx boards there is an additional SoM layer (DHCOM)
between. Therefore, in version 4 I will also adapt the DHCOM SoM layer.


Thanks and best regards
Christoph