Re: [PATCH] dax: enable dax fault handler to report VM_FAULT_HWPOISON

From: Jane Chu
Date: Thu Apr 06 2023 - 16:42:25 EST


On 4/6/2023 12:32 PM, Matthew Wilcox wrote:
On Thu, Apr 06, 2023 at 11:55:56AM -0600, Jane Chu wrote:
static vm_fault_t dax_fault_return(int error)
{
if (error == 0)
return VM_FAULT_NOPAGE;
- return vmf_error(error);
+ else if (error == -ENOMEM)
+ return VM_FAULT_OOM;
+ else if (error == -EHWPOISON)
+ return VM_FAULT_HWPOISON;
+ return VM_FAULT_SIGBUS;
}

Why would we want to handle it here instead of changing vmf_error()?

I think it's related to the comment about the the corrupted range of
a hwpoison caused fault - something no need to worry about now.

I will move the change to vmf_error() in a respin.

Thanks!
-jane