Re: [PATCH v1 2/2] iio: adc: adding support for pac193x

From: kernel test robot
Date: Mon Feb 20 2023 - 15:05:37 EST


Hi,

I love your patch! Perhaps something to improve:

[auto build test WARNING on jic23-iio/togreg]
[also build test WARNING on linus/master v6.2 next-20230220]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/marius-cristea-microchip-com/dt-bindings-iio-adc-adding-dt-bindings-for-PAC193X/20230220-203540
base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
patch link: https://lore.kernel.org/r/20230220123232.413029-3-marius.cristea%40microchip.com
patch subject: [PATCH v1 2/2] iio: adc: adding support for pac193x
config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20230221/202302210331.iKaMm4co-lkp@xxxxxxxxx/config)
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/fd3be916ffe18735a98bdc55ccc0cb5f3097582c
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review marius-cristea-microchip-com/dt-bindings-iio-adc-adding-dt-bindings-for-PAC193X/20230220-203540
git checkout fd3be916ffe18735a98bdc55ccc0cb5f3097582c
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/iio/adc/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Link: https://lore.kernel.org/oe-kbuild-all/202302210331.iKaMm4co-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

drivers/iio/adc/pac193x.c: In function 'pac193x_acpi_get_acpi_match_entry':
>> drivers/iio/adc/pac193x.c:1402:21: warning: variable 'status' set but not used [-Wunused-but-set-variable]
1402 | acpi_status status;
| ^~~~~~


vim +/status +1402 drivers/iio/adc/pac193x.c

1399
1400 static char *pac193x_acpi_get_acpi_match_entry(acpi_handle handle)
1401 {
> 1402 acpi_status status;
1403 union acpi_object *name_object;
1404 struct acpi_buffer buffer = {ACPI_ALLOCATE_BUFFER, NULL};
1405
1406 status = acpi_evaluate_object(handle, "_HID", NULL, &buffer);
1407 name_object = buffer.pointer;
1408
1409 return name_object->string.pointer;
1410 }
1411

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests