Re: [PATCH v1 2/7] xhci: mem: Use __GFP_ZERO instead of explicit memset() call

From: Andy Shevchenko
Date: Tue Feb 07 2023 - 17:50:01 EST


On Tue, Feb 07, 2023 at 05:11:23PM +0200, Mathias Nyman wrote:
> On 6.2.2023 18.10, Andy Shevchenko wrote:
> > Use __GFP_ZERO instead of explicit memset() call in
> > xhci_alloc_stream_ctx().

...

> > + mem_flags |= __GFP_ZERO;
>
> How about calling dma_pool_zalloc() instead of setting __GFP_ZERO flag?
> Memory returned by dma_alloc_coherent() should already be zeroed if I remember correctly

That will work too.

--
With Best Regards,
Andy Shevchenko