Re: [PATCH v9] module: replace module_layout with module_memory

From: Song Liu
Date: Tue Feb 07 2023 - 17:15:57 EST




> On Feb 7, 2023, at 2:13 AM, Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
>
> On Mon, Feb 06 2023 at 23:27, Song Liu wrote:
>>> On Feb 6, 2023, at 1:45 PM, Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
>>>> +static void free_mod_mem(struct module *mod)
>>>> +{
>>>> + /* free the memory in the right order to avoid use-after-free */
>>>
>>> How do we end up with a UAF when the ordering is different?
>>
>> IIUC, we need remove MOD_DATA at last, which hosts "mod".
>
> Oh. Please add a comment to that effect.
>

Oops, I sent v10 too fast.

Thanks,
Song