Re: [PATCH v5 1/6] dt-bindings: phy: Add qcom,snps-eusb2-phy schema file

From: Rob Herring
Date: Tue Feb 07 2023 - 13:44:28 EST



On Tue, 07 Feb 2023 13:40:19 +0200, Abel Vesa wrote:
> The SM8550 SoC uses Synopsis eUSB2 PHY. Add a dt-binding schema
> for the new driver.
>
> Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxx>
> ---
>
> There will be a binding check warning from Rob's bot because of the tcsr
> clock bindings missing (dt-bindings/clock/qcom,sm8550-tcsr.h), but that
> is expected as the header is already merged through Bjorn's clocks tree.
>
> The v4 version of this patch was here:
> https://lore.kernel.org/all/20230202132511.3983095-2-abel.vesa@xxxxxxxxxx/
>
> Changes since v4:
> * none
>
> Changes since v3:
> * removed blank line, like Rob suggested
> * dropped quotes and reset description, like Rob suggested
> * dropped the RPMH_CXO_PAD_CLK clock and the ref_src clock name
> to match the schema
> * fixed filenames of the includes in the example (sm8550-gcc and
> sm8550-tcsr)
>
> Changes since v2:
> * none
>
> Changes since v1:
> * dropped the "ref src" clock
> * dropped the usb-repeater property
>
>
> .../bindings/phy/qcom,snps-eusb2-phy.yaml | 74 +++++++++++++++++++
> 1 file changed, 74 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml
>

Reviewed-by: Rob Herring <robh@xxxxxxxxxx>