Re: [PATCH v2] proc: remove mark_inode_dirty() in .setattr()

From: Alexey Dobriyan
Date: Tue Feb 07 2023 - 13:18:05 EST


On Tue, Jan 31, 2023 at 11:08:40PM +0800, Chao Yu wrote:
> procfs' .setattr() has updated i_uid, i_gid and i_mode into proc
> dirent, we don't need to call mark_inode_dirty() for delayed
> update, remove it.

> --- a/fs/proc/base.c
> +++ b/fs/proc/base.c
> @@ -699,7 +699,6 @@ int proc_setattr(struct user_namespace *mnt_userns, struct dentry *dentry,
> return error;
>
> setattr_copy(&init_user_ns, inode, attr);
> - mark_inode_dirty(inode);

Reviewed-by: Alexey Dobriyan <adobriyan@xxxxxxxxx>