Re: [Patch v2 4/5] KVM: x86/mmu: Remove handle_changed_spte_dirty_log()

From: Vipin Sharma
Date: Tue Feb 07 2023 - 12:52:40 EST


On Mon, Feb 6, 2023 at 3:59 PM David Matlack <dmatlack@xxxxxxxxxx> wrote:
>
> On Fri, Feb 03, 2023 at 11:28:21AM -0800, Vipin Sharma wrote:
> > Remove handle_changed_spte_dirty_log() as there is no code flow which
> > sets leaf SPTE writable and hit this path.
>
> Heh, way too vague again. e.g. This needs to explain how make_spte()
> marks pages are dirty when constructing new SPTEs for the TDP MMU.

Okay, I will try to be more detailed in the next version.