Re: [PATCH] scsi: dc395x: Replace arithmetic addition by bitwise OR

From: Deepak R Varma
Date: Tue Feb 07 2023 - 12:51:20 EST


On Tue, Feb 07, 2023 at 03:25:09PM +0100, Oliver Neukum wrote:
>
>
> On 07.02.23 09:49, Deepak R Varma wrote:
> > When adding two bit-field mask values, an OR operation offers higher
> > performance over an arithmetic operation.
>
> Hi,
>
> I am sorry, but this change log makes no sense. These are constants.
> The compiler turns that into one value in any case.

Hello Oliver,
Yes, I received a feedback for another similar patch. Please disregard my patch
proposal.

> If you do a clean up, say so.
I did not understand this comment. Are you suggesting another opportunity that I
can take up? Could you share some details please?

Thank you.
deepak

>
> Regards
> Oliver
>