Re: [PATCH -next v3] block, bfq: cleanup 'bfqg->online'

From: Jens Axboe
Date: Tue Feb 07 2023 - 12:21:26 EST



On Thu, 02 Feb 2023 21:49:13 +0800, Yu Kuai wrote:
> After commit dfd6200a0954 ("blk-cgroup: support to track if policy is
> online"), there is no need to do this again in bfq.
>
> However, 'pd->online' is not protected by 'bfqd->lock', in order to make
> sure bfq won't see that 'pd->online' is still set after bfq_pd_offline(),
> clear it before bfq_pd_offline() is called. This is fine because other
> polices doesn't use 'pd->online' and bfq_pd_offline() will move active
> bfqq to root cgroup anyway.
>
> [...]

Applied, thanks!

[1/1] block, bfq: cleanup 'bfqg->online'
commit: f37bf75ca73d523ebaa7ceb44c45d8ecd05374fe

Best regards,
--
Jens Axboe