Re: [PATCH v13 1/6] thermal: drivers: mediatek: Relocate driver to mediatek folder
From: kernel test robot
Date: Tue Feb 07 2023 - 11:14:41 EST
Hi,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on a2c81dc59d41e92362ab7d41d0c15471ea50637d]
url: https://github.com/intel-lab-lkp/linux/commits/bchihi-baylibre-com/thermal-drivers-mediatek-Relocate-driver-to-mediatek-folder/20230207-211351
base: a2c81dc59d41e92362ab7d41d0c15471ea50637d
patch link: https://lore.kernel.org/r/20230207130958.608305-2-bchihi%40baylibre.com
patch subject: [PATCH v13 1/6] thermal: drivers: mediatek: Relocate driver to mediatek folder
config: sparc-allyesconfig (https://download.01.org/0day-ci/archive/20230208/202302080018.wNeWiKqz-lkp@xxxxxxxxx/config)
compiler: sparc64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/0eb89997925c0d7b47bbeee93016146fc660b259
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review bchihi-baylibre-com/thermal-drivers-mediatek-Relocate-driver-to-mediatek-folder/20230207-211351
git checkout 0eb89997925c0d7b47bbeee93016146fc660b259
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc SHELL=/bin/bash drivers/thermal/mediatek/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
All warnings (new ones prefixed by >>):
>> drivers/thermal/mediatek/auxadc_thermal.c:562: warning: expecting prototype for raw_to_mcelsius(). Prototype was for raw_to_mcelsius_v1() instead
vim +562 drivers/thermal/mediatek/auxadc_thermal.c
a4ffe6b52d27f4 drivers/thermal/mtk_thermal.c Michael Kao 2019-02-01 551
a92db1c8089e82 drivers/thermal/mtk_thermal.c Sascha Hauer 2015-11-30 552 /**
a92db1c8089e82 drivers/thermal/mtk_thermal.c Sascha Hauer 2015-11-30 553 * raw_to_mcelsius - convert a raw ADC value to mcelsius
a92db1c8089e82 drivers/thermal/mtk_thermal.c Sascha Hauer 2015-11-30 554 * @mt: The thermal controller
3772bb422072d4 drivers/thermal/mtk_thermal.c Amit Kucheria 2019-11-20 555 * @sensno: sensor number
a92db1c8089e82 drivers/thermal/mtk_thermal.c Sascha Hauer 2015-11-30 556 * @raw: raw ADC value
a92db1c8089e82 drivers/thermal/mtk_thermal.c Sascha Hauer 2015-11-30 557 *
a92db1c8089e82 drivers/thermal/mtk_thermal.c Sascha Hauer 2015-11-30 558 * This converts the raw ADC value to mcelsius using the SoC specific
a92db1c8089e82 drivers/thermal/mtk_thermal.c Sascha Hauer 2015-11-30 559 * calibration constants
a92db1c8089e82 drivers/thermal/mtk_thermal.c Sascha Hauer 2015-11-30 560 */
54bf1e5a629dfb drivers/thermal/mtk_thermal.c Henry Yen 2020-04-30 561 static int raw_to_mcelsius_v1(struct mtk_thermal *mt, int sensno, s32 raw)
a92db1c8089e82 drivers/thermal/mtk_thermal.c Sascha Hauer 2015-11-30 @562 {
a92db1c8089e82 drivers/thermal/mtk_thermal.c Sascha Hauer 2015-11-30 563 s32 tmp;
a92db1c8089e82 drivers/thermal/mtk_thermal.c Sascha Hauer 2015-11-30 564
a92db1c8089e82 drivers/thermal/mtk_thermal.c Sascha Hauer 2015-11-30 565 raw &= 0xfff;
a92db1c8089e82 drivers/thermal/mtk_thermal.c Sascha Hauer 2015-11-30 566
a92db1c8089e82 drivers/thermal/mtk_thermal.c Sascha Hauer 2015-11-30 567 tmp = 203450520 << 3;
f84514766985d3 drivers/thermal/mtk_thermal.c Michael Kao 2019-02-01 568 tmp /= mt->conf->cali_val + mt->o_slope;
a92db1c8089e82 drivers/thermal/mtk_thermal.c Sascha Hauer 2015-11-30 569 tmp /= 10000 + mt->adc_ge;
a92db1c8089e82 drivers/thermal/mtk_thermal.c Sascha Hauer 2015-11-30 570 tmp *= raw - mt->vts[sensno] - 3350;
a92db1c8089e82 drivers/thermal/mtk_thermal.c Sascha Hauer 2015-11-30 571 tmp >>= 3;
a92db1c8089e82 drivers/thermal/mtk_thermal.c Sascha Hauer 2015-11-30 572
a92db1c8089e82 drivers/thermal/mtk_thermal.c Sascha Hauer 2015-11-30 573 return mt->degc_cali * 500 - tmp;
a92db1c8089e82 drivers/thermal/mtk_thermal.c Sascha Hauer 2015-11-30 574 }
a92db1c8089e82 drivers/thermal/mtk_thermal.c Sascha Hauer 2015-11-30 575
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests