Re: [PATCH v9 23/27] virt: gunyah: Add IO handlers

From: Srivatsa Vaddagiri
Date: Tue Feb 07 2023 - 07:19:47 EST


* Elliot Berman <quic_eberman@xxxxxxxxxxx> [2023-02-06 19:59:30]:

> > > +int gh_vm_mgr_add_io_handler(struct gunyah_vm *ghvm, struct gunyah_vm_io_handler *io_hdlr)
> > > +{
> > > + struct rb_node **root, *parent = NULL;
> > > +
> > > + if (io_hdlr->datamatch &&
> > > + (!io_hdlr->len || io_hdlr->len > (sizeof(io_hdlr->data) * BITS_PER_BYTE)))


io_hdlr->len represents length in bytes AFAICS so the above test should be:

(!io_hdlr->len || io_hdlr->len > (sizeof(io_hdlr->data) )))

?