Re: sound/soc/soc-topology.c:1405 soc_tplg_dapm_widget_create() warn: missing error code 'ret'

[Dan Carpenter]

On Tue, Feb 07, 2023 at 12:34:09PM +0100, Amadeusz Sławiński wrote:
> On 2/7/2023 11:08 AM, Dan Carpenter wrote:
> > Hi Amadeusz,
> > 
> > FYI, the error/warning was bisected to this commit, please ignore it if it's irrelevant.
> > 
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > head:   05ecb680708a1dbe6554d6fc17e5d9a8a7cb5e6a
> > commit: 47a1886a610aca6a55c18ee677f9176e73162e97 ASoC: Intel: avs: Enable AVS driver only on x86 platforms
> > config: microblaze-randconfig-m041-20230206 (https://download.01.org/0day-ci/archive/20230207/202302071823.2veEqSHM-lkp@xxxxxxxxx/config)
> > compiler: microblaze-linux-gcc (GCC) 12.1.0
> > 
> > If you fix the issue, kindly add following tag where applicable
> > | Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > | Reported-by: Dan Carpenter <error27@xxxxxxxxx>
> > 
> 
> Oh, I've already noticed this one when doing some cleanups to the file and
> have patch queued internally, but will add above tags and Fixes tag and send
> it upstream separately.
> 
> The issue itself was introduced by commit:
> d29d41e28eea65 "ASoC: topology: Add support for multiple kcontrol types to a
> widget" not by the one it bisected to ;)
> 

That's handled by the Intel team and the kbuild-bot.  However, I wasn't
able to compile the d29d41e28eea65 "ASoC: topology: Add support for ..."
commit because of a build error in other parts of the kernel.  I first
had to apply:

Fixes: 52a9dab6d892 ("libsubcmd: Fix use-after-free for realloc(..., 0)")

So maybe the build breakage messed up git bisect.  Not sure.

regards,
dan carpenter