Re: [PATCH v4 3/4] crypto/net/ipv6: sr: Switch to using crypto_pool

From: Dan Carpenter
Date: Tue Feb 07 2023 - 06:40:20 EST


Hi Dmitry,

url: https://github.com/intel-lab-lkp/linux/commits/Dmitry-Safonov/crypto-Introduce-crypto_pool/20230119-054258
base: c1649ec55708ae42091a2f1bca1ab49ecd722d55
patch link: https://lore.kernel.org/r/20230118214111.394416-4-dima%40arista.com
patch subject: [PATCH v4 3/4] crypto/net/ipv6: sr: Switch to using crypto_pool
config: s390-randconfig-m041-20230206 (https://download.01.org/0day-ci/archive/20230207/202302071833.k6CihGFl-lkp@xxxxxxxxx/config)
compiler: s390-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Reported-by: Dan Carpenter <error27@xxxxxxxxx>

smatch warnings:
net/ipv6/seg6.c:539 seg6_init() warn: ignoring unreachable code.

vim +539 net/ipv6/seg6.c

4f4853dc1c9c19 David Lebrun 2016-11-08 532
915d7e5e5930b4 David Lebrun 2016-11-08 533 pr_info("Segment Routing with IPv6\n");
915d7e5e5930b4 David Lebrun 2016-11-08 534
915d7e5e5930b4 David Lebrun 2016-11-08 535 out:
915d7e5e5930b4 David Lebrun 2016-11-08 536 return err;
754f6619437c57 Dmitry Safonov 2023-01-18 537
46738b1317e169 David Lebrun 2016-11-15 538 #ifdef CONFIG_IPV6_SEG6_LWTUNNEL
d1df6fd8a1d22d David Lebrun 2017-08-05 @539 seg6_local_exit();

Not a bug. Just dead code. Some people like to store dead code here
for later, but it's not a common thing...

754f6619437c57 Dmitry Safonov 2023-01-18 540 out_unregister_iptun:
4f4853dc1c9c19 David Lebrun 2016-11-08 541 seg6_iptunnel_exit();
4f4853dc1c9c19 David Lebrun 2016-11-08 542 #endif
46738b1317e169 David Lebrun 2016-11-15 543 #ifdef CONFIG_IPV6_SEG6_LWTUNNEL
6c8702c60b8865 David Lebrun 2016-11-08 544 out_unregister_pernet:
6c8702c60b8865 David Lebrun 2016-11-08 545 unregister_pernet_subsys(&ip6_segments_ops);
46738b1317e169 David Lebrun 2016-11-15 546 #endif
915d7e5e5930b4 David Lebrun 2016-11-08 547 out_unregister_genl:
915d7e5e5930b4 David Lebrun 2016-11-08 548 genl_unregister_family(&seg6_genl_family);
915d7e5e5930b4 David Lebrun 2016-11-08 549 goto out;
915d7e5e5930b4 David Lebrun 2016-11-08 550 }

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests