Re: [PATCH] [v2] cpuidle: add ARCH_SUSPEND_POSSIBLE dependencies

From: Thierry Reding
Date: Tue Feb 07 2023 - 05:14:59 EST


On Mon, Feb 06, 2023 at 08:33:06PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> Some ARMv4 processors don't support suspend, which leads
> to a build failure with the tegra and qualcomm cpuidle driver:
>
> WARNING: unmet direct dependencies detected for ARM_CPU_SUSPEND
> Depends on [n]: ARCH_SUSPEND_POSSIBLE [=n]
> Selected by [y]:
> - ARM_TEGRA_CPUIDLE [=y] && CPU_IDLE [=y] && (ARM [=y] || ARM64) && (ARCH_TEGRA [=n] || COMPILE_TEST [=y]) && !ARM64 && MMU [=y]
>
> arch/arm/kernel/sleep.o: in function `__cpu_suspend':
> (.text+0x68): undefined reference to `cpu_sa110_suspend_size'
> (.text+0x68): undefined reference to `cpu_fa526_suspend_size'
>
> Add an explicit dependency to make randconfig builds avoid
> this combination.
>
> Fixes: faae6c9f2e68 ("cpuidle: tegra: Enable compile testing")
> Fixes: a871be6b8eee ("cpuidle: Convert Qualcomm SPM driver to a generic CPUidle driver")
> Link: https://lore.kernel.org/all/20211013160125.772873-1-arnd@xxxxxxxxxx/
> Cc: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx
> Reviewed-by: Dmitry Osipenko <digetx@xxxxxxxxx>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> I found this in my backlog of patches that never made it upstream,
> testing shows this is still needed. Please apply.
> ---
> drivers/cpuidle/Kconfig.arm | 2 ++
> 1 file changed, 2 insertions(+)

Acked-by: Thierry Reding <treding@xxxxxxxxxx>

Attachment: signature.asc
Description: PGP signature