Re: [PATCH v1 08/45] clk: mediatek: mt2712: Move apmixedsys clock driver to its own file

[AngeloGioacchino Del Regno]

Il 07/02/23 07:50, Chen-Yu Tsai ha scritto:
> On Mon, Feb 6, 2023 at 11:29 PM AngeloGioacchino Del Regno
> <angelogioacchino.delregno@xxxxxxxxxxxxx> wrote:
> > The only clock driver that does not support mtk_clk_simple_probe() is
> > apmixedsys: in preparation for enabling module build of non-critical
> > mt2712 clocks, move this to its own file.
> > While at it, also fix some indentation issues in the PLLs table.
> >
> > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
> > ---
> >   drivers/clk/mediatek/Makefile                |   2 +-
> >   drivers/clk/mediatek/clk-mt2712-apmixedsys.c | 152 +++++++++++++++++
> >   drivers/clk/mediatek/clk-mt2712.c            | 164 -------------------
> >   3 files changed, 153 insertions(+), 165 deletions(-)
> >   create mode 100644 drivers/clk/mediatek/clk-mt2712-apmixedsys.c
>
> `git diff --color-moved=dimmed-zebra --color-moved-ws=ignore-all-space`
> agrees this is mostly code movement.
>
> > diff --git a/drivers/clk/mediatek/Makefile b/drivers/clk/mediatek/Makefile
> > index e5d018270ed0..3c7dd19cdddf 100644
> > --- a/drivers/clk/mediatek/Makefile
> > +++ b/drivers/clk/mediatek/Makefile
> > @@ -38,7 +38,7 @@ obj-$(CONFIG_COMMON_CLK_MT2701_HIFSYS) += clk-mt2701-hif.o
> >   obj-$(CONFIG_COMMON_CLK_MT2701_IMGSYS) += clk-mt2701-img.o
> >   obj-$(CONFIG_COMMON_CLK_MT2701_MMSYS) += clk-mt2701-mm.o
> >   obj-$(CONFIG_COMMON_CLK_MT2701_VDECSYS) += clk-mt2701-vdec.o
> > -obj-$(CONFIG_COMMON_CLK_MT2712) += clk-mt2712.o
> > +obj-$(CONFIG_COMMON_CLK_MT2712) += clk-mt2712.o clk-mt2712-apmixedsys.o
> >   obj-$(CONFIG_COMMON_CLK_MT2712_BDPSYS) += clk-mt2712-bdp.o
> >   obj-$(CONFIG_COMMON_CLK_MT2712_IMGSYS) += clk-mt2712-img.o
> >   obj-$(CONFIG_COMMON_CLK_MT2712_JPGDECSYS) += clk-mt2712-jpgdec.o
> > diff --git a/drivers/clk/mediatek/clk-mt2712-apmixedsys.c b/drivers/clk/mediatek/clk-mt2712-apmixedsys.c
> > new file mode 100644
> > index 000000000000..e841be3a02c9
> > --- /dev/null
> > +++ b/drivers/clk/mediatek/clk-mt2712-apmixedsys.c
> > @@ -0,0 +1,152 @@
> > +// SPDX-License-Identifier: GPL-2.0-only
> > +/*
> > + * Copyright (c) 2017 MediaTek Inc.
> > + * Copyright (c) 2023 Collabora Ltd.
> > + * Author: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
>
> I think the original author still applies, given you are mostly just
> moving the code?

It does indeed, that was a big mistake on my side - my apologies.

> [...]
>
> > +static const struct of_device_id of_match_clk_mt2712_apmixed[] = {
> > +       { .compatible = "mediatek,mt2712-apmixedsys" },
> > +       { /* sentinel */ }
> > +};
> > +
> > +static struct platform_driver clk_mt2712_apmixed_drv = {
> > +       .probe = clk_mt2712_apmixed_probe,
> > +       .driver = {
> > +               .name = "clk-mt2712",
>
> I'd change the name as well, but I'm not sure if that constitutes a
> uAPI change.

My intention was to change this name as well, I should've better
re-checked this kind of cosmetics before sending out - I focused too
much on other kinds of re-checking action.

Noted for v2.

Cheers,
Angelo