Re: [PATCH] arm64: dts: Add support for Unisoc's UMS512

[Krzysztof Kozlowski]

On 07/02/2023 03:19, Chunyan Zhang wrote:
> On Thu, 19 Jan 2023 at 19:40, Krzysztof Kozlowski
> <krzysztof.kozlowski@xxxxxxxxxx> wrote:
>>
>> On 18/01/2023 09:40, Chunyan Zhang wrote:
>>> Add basic support for Unisoc's UMS512, with this patch,
>>> the board ums512-1h10 can run into console.
>>>
> 
> [snip]
> 
>>> +             ap-apb {
>>
>> Non-unit-address nodes cannot be mixed with unit address ones. Something
>> is wrong here.
> 
> To make sure I understand correctly, did you mean non-unit-address
> nodes shouldn't be the parent of unit-address nodes?
> 
> Does that mean the bus node should have a unique base address like:
>         ap-apb@70000000 {

No. I mean, run dtbs W=1 or dtbs_check DT_SCHEMA_FILES=simple-bus


Best regards,
Krzysztof