Re: [syzbot] kernel BUG in process_one_work

[syzbot]

Hello,

syzbot has tested the proposed patch but the reproducer is still triggering an issue:
kernel BUG in __bio_release_pages

 do_splice_direct+0x1ab/0x280 fs/splice.c:974
 do_sendfile+0xb19/0x12c0 fs/read_write.c:1255
 __do_sys_sendfile64 fs/read_write.c:1323 [inline]
 __se_sys_sendfile64 fs/read_write.c:1309 [inline]
 __x64_sys_sendfile64+0x1d0/0x210 fs/read_write.c:1309
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
------------[ cut here ]------------
kernel BUG at include/linux/mm.h:868!
invalid opcode: 0000 [#1] PREEMPT SMP KASAN
CPU: 1 PID: 1760 Comm: kworker/1:2 Not tainted 6.2.0-rc6-next-20230203-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/12/2023
Workqueue: ipv6_addrconf addrconf_dad_work
RIP: 0010:put_page_testzero include/linux/mm.h:868 [inline]
RIP: 0010:folio_put_testzero include/linux/mm.h:874 [inline]
RIP: 0010:folio_put include/linux/mm.h:1303 [inline]
RIP: 0010:put_page include/linux/mm.h:1373 [inline]
RIP: 0010:bio_release_page block/blk.h:437 [inline]
RIP: 0010:__bio_release_pages+0x546/0x610 block/bio.c:1179
Code: 04 24 48 83 e8 01 48 89 04 24 48 89 44 24 30 e9 0c fe ff ff e8 4b 6f 8b fd 48 8b 7c 24 30 48 c7 c6 40 72 a4 8a e8 0a 17 c4 fd <0f> 0b 48 8b 7c 24 08 e8 1e 72 da fd e9 f2 fa ff ff 48 8b 7c 24 08
RSP: 0018:ffffc900001e0ca0 EFLAGS: 00010246
RAX: 0000000000000000 RBX: ffffea0001f32000 RCX: 0000000000000100
RDX: ffff888021ff9d40 RSI: ffffffff83f8fb66 RDI: 0000000000000000
RBP: dffffc0000000000 R08: 0000000000000001 R09: ffffffff8e751757
R10: fffffbfff1cea2ea R11: 0000000000000001 R12: 0000000000000000
R13: ffff88802af8ba00 R14: ffffea0001f32034 R15: 0000000000000002
FS:  0000000000000000(0000) GS:ffff8880b9900000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 000055ba0a633950 CR3: 0000000075f9d000 CR4: 00000000003506e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 <IRQ>
 bio_release_pages include/linux/bio.h:493 [inline]
 iomap_dio_bio_end_io+0x373/0x5e0 fs/iomap/direct-io.c:185
 bio_endio+0x62d/0x7f0 block/bio.c:1615
 req_bio_endio block/blk-mq.c:794 [inline]
 blk_update_request+0x3a5/0x1430 block/blk-mq.c:926
 scsi_end_request+0x7a/0xa20 drivers/scsi/scsi_lib.c:537
 scsi_io_completion+0x177/0x1f80 drivers/scsi/scsi_lib.c:975
 scsi_complete+0x126/0x3b0 drivers/scsi/scsi_lib.c:1439
 blk_complete_reqs+0xad/0xe0 block/blk-mq.c:1131
 __do_softirq+0x2e3/0xae3 kernel/softirq.c:571
 do_softirq.part.0+0xde/0x130 kernel/softirq.c:472
 </IRQ>
 <TASK>
 do_softirq kernel/softirq.c:464 [inline]
 __local_bh_enable_ip+0x106/0x130 kernel/softirq.c:396
 local_bh_enable include/linux/bottom_half.h:33 [inline]
 rcu_read_unlock_bh include/linux/rcupdate.h:843 [inline]
 ip6_finish_output2+0x5be/0x1590 net/ipv6/ip6_output.c:135
 __ip6_finish_output net/ipv6/ip6_output.c:195 [inline]
 ip6_finish_output+0x694/0x1170 net/ipv6/ip6_output.c:206
 NF_HOOK_COND include/linux/netfilter.h:291 [inline]
 ip6_output+0x1f1/0x540 net/ipv6/ip6_output.c:227
 dst_output include/net/dst.h:444 [inline]
 NF_HOOK include/linux/netfilter.h:302 [inline]
 ndisc_send_skb+0xa63/0x1850 net/ipv6/ndisc.c:508
 ndisc_send_ns+0xaa/0x130 net/ipv6/ndisc.c:666
 addrconf_dad_work+0xbf4/0x1390 net/ipv6/addrconf.c:4176
 process_one_work+0x9bf/0x1820 kernel/workqueue.c:2390
 worker_thread+0x669/0x1090 kernel/workqueue.c:2537
 kthread+0x2e8/0x3a0 kernel/kthread.c:376
 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:308
 </TASK>
Modules linked in:
---[ end trace 0000000000000000 ]---
RIP: 0010:put_page_testzero include/linux/mm.h:868 [inline]
RIP: 0010:folio_put_testzero include/linux/mm.h:874 [inline]
RIP: 0010:folio_put include/linux/mm.h:1303 [inline]
RIP: 0010:put_page include/linux/mm.h:1373 [inline]
RIP: 0010:bio_release_page block/blk.h:437 [inline]
RIP: 0010:__bio_release_pages+0x546/0x610 block/bio.c:1179
Code: 04 24 48 83 e8 01 48 89 04 24 48 89 44 24 30 e9 0c fe ff ff e8 4b 6f 8b fd 48 8b 7c 24 30 48 c7 c6 40 72 a4 8a e8 0a 17 c4 fd <0f> 0b 48 8b 7c 24 08 e8 1e 72 da fd e9 f2 fa ff ff 48 8b 7c 24 08
RSP: 0018:ffffc900001e0ca0 EFLAGS: 00010246
RAX: 0000000000000000 RBX: ffffea0001f32000 RCX: 0000000000000100
RDX: ffff888021ff9d40 RSI: ffffffff83f8fb66 RDI: 0000000000000000
RBP: dffffc0000000000 R08: 0000000000000001 R09: ffffffff8e751757
R10: fffffbfff1cea2ea R11: 0000000000000001 R12: 0000000000000000
R13: ffff88802af8ba00 R14: ffffea0001f32034 R15: 0000000000000002
FS:  0000000000000000(0000) GS:ffff8880b9900000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 000055ba0a633950 CR3: 0000000075f9d000 CR4: 00000000003506e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400


Tested on:

commit:         4fafd969 Add linux-next specific files for 20230203
git tree:       https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
console output: https://syzkaller.appspot.com/x/log.txt?x=1218216d480000
kernel config:  https://syzkaller.appspot.com/x/.config?x=1d2fba7d42502ca4
dashboard link: https://syzkaller.appspot.com/bug?extid=c0998868487c1f7e05e5
compiler:       gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2
patch:          https://syzkaller.appspot.com/x/patch.diff?x=153c325b480000