Re: [PATCH v2 04/22] rtc: pm8xxx: drop bogus locking

[David Collins]

On 2/2/23 07:54, Johan Hovold wrote:
> Since commit c8d523a4b053 ("drivers/rtc/rtc-pm8xxx.c: rework to support
> pm8941 rtc") which removed the shadow control register there is no need
> for a driver lock.
> 
> Specifically, the rtc ops are serialised by rtc core and the interrupt
> handler only unconditionally disables the alarm using the alarm_ctrl
> register.
> 
> Note that since only the alarm enable bit of alarm_ctrl is used after
> enabling the RTC at probe, the locking was not needed when doing open
> coded read-modify-write cycles either.
> 
> Signed-off-by: Johan Hovold <johan+linaro@xxxxxxxxxx>
> ---
>  drivers/rtc/rtc-pm8xxx.c | 67 +++++++++++++---------------------------
>  1 file changed, 21 insertions(+), 46 deletions(-)

Reviewed-by: David Collins <quic_collinsd@xxxxxxxxxxx>

Take care,
David