Re: [PATCH 12/22] powerpc/cpu: Mark start_secondary_resume() __noreturn

From: Josh Poimboeuf
Date: Mon Feb 06 2023 - 17:22:16 EST


On Mon, Feb 06, 2023 at 10:10:22PM +1100, Michael Ellerman wrote:
> Josh Poimboeuf <jpoimboe@xxxxxxxxxx> writes:
> > start_secondary_resume() doesn't return. Annotate it as such. By
> > extension this also makes arch_cpu_idle_dead() noreturn.
>
> Can we also mark arch_cpu_idle_dead() (the C function) __noreturn ?
>
> Seems like it would be good documentation, even if it's not required
> once the generic prototype is __noreturn.

Yeah, agreed. Maybe I'll do that (for all the implementations) with
patch 22.

> But not a show-stopper.
>
> Acked-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx> (powerpc)

Thanks!

--
Josh