Re: [PATCH v2 4/4] locktorture: With nested locks, occasionally skip main lock

From: John Stultz
Date: Mon Feb 06 2023 - 15:38:21 EST


On Sun, Feb 5, 2023 at 11:33 AM Davidlohr Bueso <dave@xxxxxxxxxxxx> wrote:
> On Fri, 03 Feb 2023, John Stultz wrote:
>
> >@@ -754,21 +755,28 @@ static int lock_torture_writer(void *arg)
> > schedule_timeout_uninterruptible(1);
> >
> > lockset_mask = torture_random(&rand);
> >+ skip_main_lock = nlocks && !(torture_random(&rand) % 100);
>
> For the sake of future readers of locktorture.c, this deserves a comment
> as to why we wanna skip the main lock (copy/paste from the changelog).

Good point! I'll send this update out soon.

Thanks again for the review and feedback!
-john