Re: [PATCH] arm64: dts: mt7986: set Wifi Leds low-active for BPI-R3

[Matthias Brugger]

On 05/02/2023 18:48, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>
>
> Leds for Wifi are low-active, so add property to devicetree.
>
> Signed-off-by: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>
> ---
>   arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
> index 33bd6febc160..2b028141f1f7 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
> @@ -446,5 +446,9 @@ &wifi {
>   	pinctrl-names = "default", "dbdc";
>   	pinctrl-0 = <&wf_2g_5g_pins>, <&wf_led_pins>;
>   	pinctrl-1 = <&wf_dbdc_pins>, <&wf_led_pins>;
> +
> +	led {
> +		led-active-low;
> +	};

The binding is missing this property also the driver implements it. Could you 
please update the bindind description properly?
Thanks
Matthias