Re: [PATCH] [RESEND v4] printf: fix errname.c list

From: Rasmus Villemoes
Date: Mon Feb 06 2023 - 15:00:19 EST


On 06/02/2023 20.40, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> On most architectures, gcc -Wextra warns about the list of error
> numbers containing both EDEADLK and EDEADLOCK:
>

[...]

> To ensure these are correct, add static_assert lines that verify
> all the remaining aliases are in fact identical to the canonical
> name.
>
> Fixes: 57f5677e535b ("printf: add support for printing symbolic error names")
> Cc: Petr Mladek <pmladek@xxxxxxxx>
> Suggested-by: Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx>

You may also add Acked-by: me.

> Acked-by: Uwe Kleine-König <uwe@xxxxxxxxxxxxxxxxx>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> Link: https://lore.kernel.org/all/20210514213456.745039-1-arnd@xxxxxxxxxx/
> Link: https://lore.kernel.org/all/20210927123409.1109737-1-arnd@xxxxxxxxxx/
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> I sent this a few times, but it never made it in so far. The warning
> still shows up when enabling extra warnings, and this is an actual bug.

Petr, please pick this up.

Rasmus