Re: [PATCH V6 2/2] mm: shmem: implement POSIX_FADV_[WILL|DONT]NEED for shmem

From: Matthew Wilcox
Date: Mon Feb 06 2023 - 11:19:19 EST


On Mon, Feb 06, 2023 at 07:51:33PM +0530, Charan Teja Kalla wrote:
> +static int shmem_fadvise_willneed(struct address_space *mapping,
> + pgoff_t start, pgoff_t long end)
> +{
> + struct page *page;
> + pgoff_t index;
> +
> + xa_for_each_range(&mapping->i_pages, index, page, start, end) {
> + if (!xa_is_value(page))
> + continue;
> + page = shmem_read_mapping_page(mapping, index);
> + if (!IS_ERR(page))
> + put_page(page);
> + }
> +
> + return 0;
> +}

Hm, that's a gap in the shmem folio API. Patches imminent.