Re: [PATCH -next] blk-throttle: enable io throttle for root in cgroup v2

[Michal Koutný]

On Sun, Feb 05, 2023 at 05:55:41PM +0200, Ofir Gal <ofir.gal@xxxxxxxxxxx> wrote:
> I have tried to limit the SSD on Server #1, but it seems that the NVME
> target kworkers are not affected unless I use Yu Kuai's patch.
> 
> Can you elaborate on the issues with this patch or how the scenario
> described above can be done with cgroups v2?

The issue is that if there's a client that doesn't implement
self-throttling you cannot guarantee anything on the server side.
Hence the mechanism must exist on the server side.

The NVME target should charge IO to respective blkcg's (just a generic
advice, I'm not familiar with that interface; see also
kthread_associate_blkcg() use in loop device driver).

HTH,
Michal

Attachment: signature.asc
Description: Digital signature