Re: [RESEND PATCH 30/37] nvmem: core: fix nvmem_layout_get_match_data()

From: Rafał Miłecki
Date: Mon Feb 06 2023 - 09:37:59 EST


On 2023-02-06 13:04, Greg KH wrote:
On Mon, Feb 06, 2023 at 10:27:52AM +0000, Srinivas Kandagatla wrote:
From: Rafał Miłecki <rafal@xxxxxxxxxx>

This function was trying to match wrong OF node (parent device's)
against an of_match_table. It was always returning NULL.

Make it match layout's OF node against layout's of_match_table.

Note: __maybe_unused is needed to avoid:
warning: variable 'layout_np' set but not used [-Wunused-but-set-variable]
(of_match_node() is no-op without CONFIG_OF).

Fixes: 61a093b4a0e0 ("nvmem: core: introduce NVMEM layouts")

Nit, how can you have a git commit id if you are sending me patches to
be applied to my tree?

That's never going to work, sorry.

That was commit I found in the:
https://git.kernel.org/pub/scm/linux/kernel/git/srini/nvmem.git/log/?h=for-next

With Srinivas sending patches and not merge request, it doesn't make
sense obviously.

Srinivas could you rebase your branch making my patch a fixup for the
commit 61a093b4a0e0?