Re: [PATCH 1/5] dt-bindings: display: msm: dp-controller: document SM8450 compatible

[Dmitry Baryshkov]

On 06/02/2023 12:33, Krzysztof Kozlowski wrote:
> On 06/02/2023 11:17, Neil Armstrong wrote:
> > The SM8450 & SM350 shares the same DT TX IP version, use the
> > SM8350 compatible as fallback for SM8450.
> >
> > Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> > ---
> >   Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 4 ++++
> >   1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> > index 0e8d8df686dc..98bae326e655 100644
> > --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> > +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> > @@ -25,6 +25,10 @@ properties:
> >         - qcom,sc8280xp-edp
> >         - qcom,sdm845-dp
> >         - qcom,sm8350-dp
> > +      - items:
> > +          - enum:
> > +            - qcom,sm8450-dp
>
> Indentation looks wrong here. Testing should fail, did you test it?

Moreover it also breaks dt-schema, see 
https://github.com/devicetree-org/dt-schema/issues/98

> Best regards,
> Krzysztof

--
With best wishes
Dmitry