Re: [PATCH net-next] net: lan966x: Add support for TC flower filter statistics

From: Simon Horman
Date: Mon Feb 06 2023 - 05:42:30 EST


On Mon, Feb 06, 2023 at 11:32:52AM +0100, Horatiu Vultur wrote:
> The 02/06/2023 10:59, Simon Horman wrote:
> >
> > > > Also, not strictly related, but could you consider, as a favour to
> > > > reviewers, fixing the driver so that the following doesn't fail:
> > > >
> > > > $ make drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.o
> > > > DESCEND objtool
> > > > CALL scripts/checksyscalls.sh
> > > > CC drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.o
> > > > In file included from drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.c:3:
> > > > drivers/net/ethernet/microchip/lan966x/lan966x_main.h:18:10: fatal error: vcap_api.h: No such file or directory
> > > > 18 | #include <vcap_api.h>
> > > > | ^~~~~~~~~~~~
> > > > compilation terminated.
> > >
> > > I will try to have a look at this.
> >
> > Thanks, much appreciated.
>
> Sorry for coming back to this, but it seems that I can't reproduce the
> issue:
>
> $ make drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.o
> CALL scripts/checksyscalls.sh
> DESCEND objtool
> CC drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.o
>
> I have tried different configurations without any luck. Any suggestion
> on how to reproduce the issue?

Sorry, perhaps it is something on my side.

I tried running through the steps below, which is what I assume
I had done last time, but I don't see the problem any more.

I'll let you know if it shows up again.
But in the meantime sorry for the false reporting.

$ git checkout net-next/main
$ make allmodconfig
$ make prepare
$ make drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.o