RE: [PATCH v3 2/4] tty: n_gsm: add keep alive support

From: Starke, Daniel
Date: Mon Feb 06 2023 - 05:38:58 EST


> > +static int gsm_config_ext(struct gsm_mux *gsm, struct gsm_config_ext *ce)
> > +{
> > + unsigned int i;
> > +
> > + gsm->keep_alive = ce->keep_alive;
> > + /*
> > + * Check that userspace doesn't put stuff in here to prevent breakages
> > + * in the future.
> > + */
> > + for (i = 0; i < ARRAY_SIZE(ce->reserved); i++)
> > + if (ce->reserved[i])
> > + return -EINVAL;
>
> Do the check before you save off the keep_alive variable?

Thank you for this hint!
I will change this and send a new version of this patch series.

Best regards,
Daniel Starke