Re: [PATCH net-next v2] rfkill: Use sysfs_emit() to instead of sprintf()
From: Simon Horman
Date: Mon Feb 06 2023 - 05:06:24 EST
On Mon, Feb 06, 2023 at 03:16:41AM -0500, Bo Liu wrote:
> Follow the advice of the Documentation/filesystems/sysfs.rst and show()
> should only use sysfs_emit() or sysfs_emit_at() when formatting the
> value to be returned to user space.
>
> Signed-off-by: Bo Liu <liubo03@xxxxxxxxxx>
> ---
> net/rfkill/core.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
Hi Bo Liu,
A brief summary of changes since v1 should go here.
Comparing v1 and v2 manually, I see that you have addressed the minor
issues raised in the review of v1:
* the checkpatch warning regarding ' )'
* Including target tree, net-next, in subject
Ref: https://lore.kernel.org/netdev/Y91bc2LWMl+DsjcW@xxxxxxxxxxxx/
So, FWIIW, I am happy with this patch now.
Reviewed-by: Simon Horman <simon.horman@xxxxxxxxxxxx>