RE: [PATCH net v2 2/2] net: ll_temac: Reset buffer on dma_map_single() errors

[Katakam, Harini]

Hi Jonas,

> -----Original Message-----
> From: Jonas Suhr Christensen <jsc@xxxxxxxxxxxxxx>
> Sent: Monday, February 6, 2023 1:41 AM
> To: netdev@xxxxxxxxxxxxxxx
> Cc: jsc@xxxxxxxxxxxxxx; David S. Miller <davem@xxxxxxxxxxxxx>; Eric
> Dumazet <edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>;
> Paolo Abeni <pabeni@xxxxxxxxxx>; Michal Simek
> <michal.simek@xxxxxxxxxx>; Katakam, Harini <harini.katakam@xxxxxxx>;
> Haoyue Xu <xuhaoyue1@xxxxxxxxxxxxx>; huangjunxian
> <huangjunxian6@xxxxxxxxxxxxx>; Christophe JAILLET
> <christophe.jaillet@xxxxxxxxxx>; Yang Yingliang
> <yangyingliang@xxxxxxxxxx>; Esben Haabendal <esben@xxxxxxxxxx>;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: [PATCH net v2 2/2] net: ll_temac: Reset buffer on dma_map_single()
> errors
> 
> To avoid later calls to dma_unmap_single() on address'
> that fails to be mapped, free the allocated skb and
> set the pointer of the address to NULL. Eg. when a mapping
> fails temac_dma_bd_release() will try to call dma_unmap_single()
> on that address if the structure is not reset.
> 
> Fixes: d07c849cd2b9 ("net: ll_temac: Add more error handling of
> dma_map_single() calls")
> 
> Signed-off-by: Jonas Suhr Christensen <jsc@xxxxxxxxxxxxxx>

Thanks for the patch
Reviewed-by: Harini Katakam <harini.katakam@xxxxxxx>

Regards,
Harini