Re: [PATCH] x86/perf/zhaoxin: Add stepping check for ZX-C

From: Borislav Petkov
Date: Mon Feb 06 2023 - 04:48:38 EST


On Mon, Feb 06, 2023 at 04:26:25PM +0800, silviazhaooc wrote:
> Due to our company’s email policy, email address with oc suffix is used for
> sending email without confidentiality statement at the end of the mail body.
>
> I will remove –oc from my name later.

Yes, please. The email address is fine but the name doesn't have to have
that funky "-oc" thing.

> But due to some unknown historical reasons, the FMS of Nano and ZXC are only
> different in stepping.
>
> I have considered about using the “Model name string” to distinguish them,
> but it doesn't seem to be a common way in Linux kernel.

I don't mind you using steppings to differentiate the two as long as
this is not going to change all of a sudden and that differentiation is
unambiguous.

If not, you will have to use name strings as you don't have any other
choice.

Whatever you do, pls define a new X86_BUG_ flag, set it only on Nano and
then test it in the PMU init code.

Thx.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette