Re: [PATCH] mips: Realtek RTL: select NO_EXCEPT_FILL

[Olliver Schinagl]

Hey Thomas,

On 05-02-2023 17:19, Thomas Bogendoerfer wrote:
> On Sat, Jan 28, 2023 at 03:39:59PM +0100, Olliver Schinagl wrote:
> > Thanks Thomas, may I take this moment to poke you about a nother issue I
> > don't quite understand how to resolve/figure out.
> >
> >
> > I made the realtek target work with the GENERIC_MIPS_KERNEL, but only if I
> > disable SWAP_IO_SPACE[0].
>
> is this little endian or big endian ?
The kernel config currently states Big Endian

> > While I could act all smart and ask what this is for, I better ask, why is
> > this concidered 'generic'. The comment in mangle-port [1] mentions 'sane
> > hardware'. I don't know what is considered sane here, as the number of
> > targets following generic mips seem to be around 5.
>
> I always thought that SWAP_IO_SPACE is needed for big endian, but
> looking at arch/mips/Kconfig I see a lot of SWAP_IO_SPACE for pure
> little endian machines. I need to dig deeper to understand why.
Thank you!

> > So any pointers (other then doing SWAP_IO_SPACE if !REALTEK_SOC, which I
> > have now) would be appreciated
>
> such a change would defeat the generic part of GENERIC_MIPS_KERNEL,
> because it will then only work on REALTEC_SOC and nothing else.
Ignoring the potential incorrect detail here, obviously I would prefer 
to use the GENERIC_MIPS_KERNEL, but having to copy the whole config just 
to leave out that one option also is kinda meh. So i'm hoping we can 
find a solution of course :)

Olliver

> Thomas.