Re: [PATCH v2] iio: temperature: Add MCP9600 thermocouple EMF converter driver

[Jonathan Cameron]

On Thu, 12 Jan 2023 19:05:51 +0000
Jonathan Cameron <jic23@xxxxxxxxxx> wrote:

> On Sun,  8 Jan 2023 15:45:04 -0800
> Andrew Hepp <andrew.hepp@xxxxxxxxx> wrote:
> 
> > From: "Andrew Hepp" <andrew.hepp@xxxxxxxxx>
> > 
> > Add support for the MCP9600 thermocouple EMF converter.
> > 
> > Datasheet: https://ww1.microchip.com/downloads/en/DeviceDoc/MCP960X-Data-Sheet-20005426.pdf
> > Signed-off-by: Andrew Hepp <andrew.hepp@xxxxxxxxx>  
> 
> Driver looks good, but now I realise we don't have a device tree binding doc.
> 
> Please add one for v3.
> 
> Note that the binding doc is describing the hardware, not what the driver
> currently supports alone, so include the 4 (or 6?) interrupt lines (and interrupt-names
> as any random subset of them might be provided) + VDD regulator + anything else I've
> not noticed in my 10 second look at the datashet.

Hi Andrew,

If you aren't going to get to this sometime soon, feel free to say so and
I might write binding docs for it if I get time.  I'd rather do that than
lose a driver over some docs!

Jonathan

> 
> Thanks,
> 
> Jonathan
>