[irqchip: irq/irqchip-next] irqchip/alpine-msi: Fix refcount leak in alpine_msix_init_domains

From: irqchip-bot for Miaoqian Lin
Date: Sun Feb 05 2023 - 06:30:08 EST


The following commit has been merged into the irq/irqchip-next branch of irqchip:

Commit-ID: 071d068b89e95d1b078aa6bbcb9d0961b77d6aa1
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/071d068b89e95d1b078aa6bbcb9d0961b77d6aa1
Author: Miaoqian Lin <linmq006@xxxxxxxxx>
AuthorDate: Mon, 02 Jan 2023 12:28:10 +04:00
Committer: Marc Zyngier <maz@xxxxxxxxxx>
CommitterDate: Sun, 05 Feb 2023 11:11:24

irqchip/alpine-msi: Fix refcount leak in alpine_msix_init_domains

of_irq_find_parent() returns a node pointer with refcount incremented,
We should use of_node_put() on it when not needed anymore.
Add missing of_node_put() to avoid refcount leak.

Fixes: e6b78f2c3e14 ("irqchip: Add the Alpine MSIX interrupt controller")
Signed-off-by: Miaoqian Lin <linmq006@xxxxxxxxx>
Signed-off-by: Marc Zyngier <maz@xxxxxxxxxx>
Link: https://lore.kernel.org/r/20230102082811.3947760-1-linmq006@xxxxxxxxx
---
drivers/irqchip/irq-alpine-msi.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/irqchip/irq-alpine-msi.c b/drivers/irqchip/irq-alpine-msi.c
index 5ddb8e5..fc1ef7d 100644
--- a/drivers/irqchip/irq-alpine-msi.c
+++ b/drivers/irqchip/irq-alpine-msi.c
@@ -199,6 +199,7 @@ static int alpine_msix_init_domains(struct alpine_msix_data *priv,
}

gic_domain = irq_find_host(gic_node);
+ of_node_put(gic_node);
if (!gic_domain) {
pr_err("Failed to find the GIC domain\n");
return -ENXIO;