Re: [PATCH v2] staging: vt6655: Macro with braces issue change to inline function

From: Greg Kroah-Hartman
Date: Sun Feb 05 2023 - 02:02:35 EST


On Sun, Feb 05, 2023 at 01:20:46AM +0100, Guru Mehar Rachaputi wrote:
> This patch is to fix checkpatch warning: "Macro argument 'iobase' may be better
> as '(iobase)' to avoid precedence issues changed to inline function.
>
> Signed-off-by: Guru Mehar Rachaputi <gurumeharrachaputi@xxxxxxxxx>
> ---
> Changes in v2:
> - Macros with one statement that calls 'iowrite8' function changed
> to inline function as reviewed by gregkh@xxxxxxxxxxxxxxxxxxx.
> In relation to this, names of the callers of macro are modified
> to call this function.
> ---

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch contains warnings and/or errors noticed by the
scripts/checkpatch.pl tool.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot
>