Re: [PATCH v2 0/4] Remove get_kernel_pages()

From: Linus Torvalds
Date: Sat Feb 04 2023 - 14:51:07 EST


On Fri, Feb 3, 2023 at 8:06 PM Ira Weiny <ira.weiny@xxxxxxxxx> wrote:
>
> This series also fixes is_kmap_addr() and uses it to ensure no kmap addresses
> slip in later.

Ack. Please make it so.

That said...

I wasn't cc'd on all the patches, but checked them on the mailing
list, and that first is_kmap_addr() patch makes me a bit unhappy.

Right now that 'is_kmap_addr()' is only used for user copy addresses,
for debugging purposes, and I'm not exactly thrilled about extending
it this way.

I get the feeling that we should just have a name for that "kmap _or_
kmap_local" range instead of making it two ranges.

But admittedly I can't come up with anything better, and it looks like
different architectures may do different things. I just don't like
it.

Linus