Re: [PATCH 2/2] Revert "PCI/ASPM: Refactor L1 PM Substates Control Register programming"

[Lukas Wunner]

On Fri, Feb 03, 2023 at 04:48:20PM -0600, Bjorn Helgaas wrote:
> Thomas Witt reported that 5e85eba6f50d ("PCI/ASPM: Refactor L1 PM Substates
> Control Register programming") broke suspend/resume on a Tuxedo
> Infinitybook S 14 v5, which seems to use a Clevo L140CU Mainboard.
> 
> The main symptom is:
> 
>   iwlwifi 0000:02:00.0: Unable to change power state from D3hot to D0, device inaccessible
>   nvme 0000:03:00.0: Unable to change power state from D3hot to D0, device inaccessible
> 
> and the machine is only partially usable after resume.  It can't run dmesg
> and can't do a clean reboot.  This happens on every suspend/resume cycle.
> 
> Revert 5e85eba6f50d until we can figure out the root cause.
> 
> Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=216877

Link: https://bugzilla.kernel.org/show_bug.cgi?id=216877
Fixes: 5e85eba6f50d ("PCI/ASPM: Refactor L1 PM Substates Control Register programming")
Cc: stable@xxxxxxxxxxxxxxx # v6.1+

> Reported-by: Thomas Witt <kernel@xxxxxxxxx>
> Tested-by: Thomas Witt <kernel@xxxxxxxxx>
> Signed-off-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> Cc: Vidya Sagar <vidyas@xxxxxxxxxx>