Re: [PATCH 00/34] selftests: Fix incorrect kernel headers search path

[Shuah Khan]

On 2/1/23 19:07, Shuah Khan wrote:
> Hi Mathieu,
>
> On 1/30/23 15:29, Shuah Khan wrote:
> > On 1/27/23 06:57, Mathieu Desnoyers wrote:
> > > Hi,
> > >
> > > This series fixes incorrect kernel header search path in kernel
> > > selftests.
> > >
> > > Near the end of the series, a few changes are not tagged as "Fixes"
> > > because the current behavior is to rely on the kernel sources uapi files
> > > rather than on the installed kernel header files. Nevertheless, those
> > > are updated for consistency.
> > >
> > > There are situations where "../../../../include/" was added to -I search
> > > path, which is bogus for userspace tests and caused issues with types.h.
> > > Those are removed.
>
> Thanks again for taking care of this. I did out of tree build testing on
> x86 on linux-kselftest next with these patches below. I haven't seen
> any problems introduced by the patch set.
>
> > >    selftests: dma: Fix incorrect kernel headers search path
> This one needs a change and I will send a patch on top of yours.
> Even with that this test depends on unexported header from the
> repo and won't build out of tree. This is not related to your
> change.
>
> > >    selftests: mount_setattr: Fix incorrect kernel headers search path
> This one fails to build with our without patch - an existing error.
>
> I have to do cross-build tests on arm64 and other arch patches still.
> This will happen later this week.

arm64, s390 patches look good.

thanks,
-- Shuah