Re: [PATCH] KVM: selftests: Remove redundant setbuf()

From: Oliver Upton
Date: Fri Feb 03 2023 - 13:50:00 EST


On Fri, Feb 03, 2023 at 06:41:27PM +0000, Sean Christopherson wrote:
> On Fri, Feb 03, 2023, shahuang@xxxxxxxxxx wrote:
> > From: Shaoqin Huang <shahuang@xxxxxxxxxx>
> >
> > Since setbuf(stdout, NULL) has been called in kvm_util.c with
> > __attribute((constructor)). Selftests no need to setup it in their own
> > code.
> >
> > Signed-off-by: Shaoqin Huang <shahuang@xxxxxxxxxx>
> > ---
>
> Reviewed-by: Sean Christopherson <seanjc@xxxxxxxxxx>

Thanks!

> Oliver/Marc, want to grab this one? I doubt there will be conflicts, but IIRC
> there are a handful of in-flight changes for aarch64/page_fault_test.c.

That is indeed the plan.

Applying patches for arm64 has taken a bit longer because I don't
yet have push access to kvmarm so I need Marc to pull from me. The net
effect is emailed thankyous are delayed by a few days, but that wont be
an issue going forward.

--
Thanks,
Oliver